Windsock kafka fix routing #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
windsock_kafka_fix_routing
branch
5 times, most recently
from
e0cc667
to
08af0f4
Compare
rukai
force-pushed
the
windsock_kafka_fix_routing
branch
from
43fa2f3
to
f8fd4a1
Compare
rukai
force-pushed
the
windsock_kafka_fix_routing
branch
2 times, most recently
from
734bfc3
to
c6b3530
Compare
rukai
force-pushed
the
windsock_kafka_fix_routing
branch
from
c6b3530
to
2b54c02
Compare
cjrolo
approved these changes
Feb 20, 2024
conorbros
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on #1419
Need to use unique keys to ensure spread across topology3 cluster, otherwise it all gets routed to a single node
Strangely the bug that I was previously also able to reproduce in #1427 is now only reproducible in the topology=3 benches with this PR.
However I've now tracked down the cause of the issue and fixed it here.
I was indexing into a vector that wasnt actually sorted.
Sorting the vector at time of creation allows us to continue indexing into as we were before but its actually guaranteed to work now. The sort only occurs when processing metadata messages so it should be fine performance wise.
The windsock results clearly show an improvement for benches with and without shotover:
Unfortunately the shotover benches are now growing a backlog:
This represents an improvement to the way we bench shotover, so no need to block on the backlog increase.
I should investigate it in the future though.